Photos are a funky topic. Unless the subject is famous or is an identifiable event (like a ball game), whether they are collectible comes down to aesthetics. If the photo is professionally done and shows period clothing or is attractive, it will sell. Wedding photos, for example, sell well if the bridal party are wearing interesting formal wear. I've also sold antique snapshots of vistas around Los Angeles. People like to see what their town looked like decades ago. You can always sell the American Dream in a photo. Someone's random beach snapshot from 50 years ago has an audience, especially if it looks like a Gidget movie, shows a surfboard, etc. Cars sell great. I picked up a random box of photos recently and found this snap of a 1955 Studebaker President Speedster:
It will sell readily. I even bought a few for the ol' PC. This is 3x Indy 500 Champ Bobby Unser at the Daytona 500 in 1965: