The US population is about 326M. If 1 in 400 people collect baseball cards then the number of collectors would be approx. 815,000 ......so that is my guess though I think a round million sounds about right.
ps...I realize there are collectors in other countries but for baseball I am pretty sure the US is the major place they are collected.